Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Moving thumbnail page numbers #943

Merged
merged 8 commits into from
Feb 26, 2019
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Chore: Pr comments
Conrad Chan committed Feb 25, 2019
commit 4c8358340f2a9848aa15e07f78d4aac5a3392234
2 changes: 1 addition & 1 deletion src/lib/ThumbnailsSidebar.js
Original file line number Diff line number Diff line change
@@ -245,7 +245,7 @@ class ThumbnailsSidebar {
this.createThumbnailImage(itemIndex).then((imageEl) => {
// Promise will resolve with null if create image request was already in progress
if (imageEl) {
// Appends to the lastChild which should be the thumbnail button element
// Appends to the lastChild which should be the thumbnail nav element
thumbnailEl.lastChild.appendChild(imageEl);
thumbnailEl.classList.add(CLASS_BOX_PREVIEW_THUMBNAIL_IMAGE_LOADED);
}