Chore: Safari fullscreen #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @ConradJChan has signed the CLA. Thanks for the pull request! |
jstoffan
reviewed
Feb 14, 2019
src/lib/_common.scss
Outdated
| position: relative; | ||
| } | ||
|
|
||
| .bp-content.bp-is-fullscreen { | ||
| background-color: $black; |
There was a problem hiding this comment.
I don't think this exists today. Should it only apply to the media player?
There was a problem hiding this comment.
Oh you're right. Today it just keeps the preview background which is #f5f5f5 I think. But in Safari, the background changed to white. I'll update it with the #f5f5f5 value and make sure it's the same experience across browsers
JustinHoldstock
approved these changes
Feb 15, 2019
ConradJChan
force-pushed
the
safari-fullscreen
branch
from
c2f56ec to
9bfcbaa
Compare
ConradJChan
pushed a commit
to ConradJChan/box-content-preview
that referenced
this pull request
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous attempt to fix this broke the adaptability of the
.bp-contentdiv from shrinking when the thumbnails sidebar was open.In this fix, only when the
.bp-is-fullscreenclass is applied, do we set the width to 100% as well as set the background-color to inherit because Safari by default does not do this for flex items in a flex container that request fullscreen. In this way, it handles both the default #f5f5f5 as well as #000 when in a media viewer's "lowered lights" mode