Fix: Prevent overwrite of cached page on presentation preview init #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @jeremypress has signed the CLA. Thanks for the pull request! |
ConradJChan
previously approved these changes
Feb 6, 2019
ConradJChan
previously approved these changes
Feb 7, 2019
| @@ -0,0 +1,35 @@ | |||
| // <reference types="Cypress" /> | |||
| describe('Preview Document Controls', () => { | |||
| beforeEach(() => { | ||
| cy.visit('/'); | ||
| cy.showPreview(token, fileId); | ||
| cy.getByTestId('current-page').as('currentPage'); |
There was a problem hiding this comment.
This doesn't seem to be used?
ConradJChan
previously approved these changes
Feb 8, 2019
jstoffan
previously approved these changes
Feb 8, 2019
| const fileId = Cypress.env('FILE_ID_PRESENTATION'); | ||
|
|
||
| /* eslint-disable */ | ||
| const showControls = () => { |
There was a problem hiding this comment.
I think this is duplicated in other test files. Should it be pulled out as a top-level helper?
JustinHoldstock
previously approved these changes
Feb 8, 2019
jeremypress
dismissed stale reviews from JustinHoldstock, jstoffan, and ConradJChan
via
2ed3c9b
JustinHoldstock
suggested changes
Feb 11, 2019
JustinHoldstock
approved these changes
Feb 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo: