-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: adding e2e tests for Thumbnails #915
Merged
ConradJChan
merged 3 commits into
box:thumbnails-sidebar
from
ConradJChan:thumbnails-e2e-tests
Feb 6, 2019
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| // <reference types="Cypress" /> | ||
| describe('Preview Document Thumbnails', () => { | ||
| const token = Cypress.env('ACCESS_TOKEN'); | ||
| const fileId = Cypress.env('FILE_ID_DOC'); | ||
| const THUMBNAIL_SELECTED_CLASS = 'bp-thumbnail-is-selected'; | ||
|
|
||
| /* eslint-disable */ | ||
| const getThumbnail = (pageNum) => cy.get(`.bp-thumbnail[data-bp-page-num=${pageNum}]`); | ||
| const showDocumentPreview = ({ enableThumbnailsSidebar } = {}) => { | ||
| cy.showPreview(token, fileId, { enableThumbnailsSidebar }); | ||
| cy.getPreviewPage(1); | ||
| cy.contains('The Content Platform for Your Apps'); | ||
| }; | ||
| const toggleThumbnails = () => { | ||
| cy.showDocumentControls(); | ||
|
|
||
| cy | ||
| .getByTitle('Toggle thumbnails') | ||
| .should('be.visible') | ||
| .click(); | ||
|
|
||
| return cy.getByTestId('thumbnails-sidebar'); | ||
| }; | ||
| /* eslint-enable */ | ||
|
|
||
| beforeEach(() => { | ||
| cy.visit('/'); | ||
| }); | ||
|
|
||
| it('Should not see the sidebar button if disabled', () => { | ||
| showDocumentPreview({ enableThumbnailsSidebar: false }); | ||
|
|
||
| cy.showDocumentControls(); | ||
| cy.getByTitle('Toggle thumbnails').should('not.be.visible'); | ||
| }); | ||
|
|
||
| it('Should see the sidebar button if enabled', () => { | ||
| showDocumentPreview({ enableThumbnailsSidebar: true }); | ||
|
|
||
| cy.showDocumentControls(); | ||
| cy.getByTitle('Toggle thumbnails').should('be.visible'); | ||
| }); | ||
|
|
||
| it('Should render thumbnails when toggled', () => { | ||
| showDocumentPreview({ enableThumbnailsSidebar: true }); | ||
|
|
||
| toggleThumbnails().should('be.visible'); | ||
|
|
||
| toggleThumbnails().should('not.be.visible'); | ||
| }); | ||
|
|
||
| it('Should be able to change page by clicking on the thumbnail', () => { | ||
| showDocumentPreview({ enableThumbnailsSidebar: true }); | ||
|
|
||
| // Verify we're on page 1 | ||
| cy.getByTestId('current-page').as('currentPage') | ||
| .invoke('text') | ||
| .should('equal', '1'); | ||
|
|
||
| toggleThumbnails().should('be.visible'); | ||
|
|
||
| // Verify which thumbnail is selected | ||
| getThumbnail(1) | ||
| .should('have.class', THUMBNAIL_SELECTED_CLASS) | ||
| .as('thumbOne'); | ||
| getThumbnail(2) | ||
| .click() | ||
| .should('have.class', THUMBNAIL_SELECTED_CLASS); | ||
| cy.get('@thumbOne').should('not.have.class', THUMBNAIL_SELECTED_CLASS); | ||
| cy | ||
| .get('@currentPage') | ||
| .invoke('text') | ||
| .should('equal', '2'); | ||
| }); | ||
|
|
||
| it('Should reflect the selected page when page is changed', () => { | ||
| showDocumentPreview({ enableThumbnailsSidebar: true }); | ||
| cy | ||
| .getByTestId('current-page') | ||
| .as('currentPage') | ||
| .invoke('text') | ||
| .should('equal', '1'); | ||
|
|
||
| toggleThumbnails().should('be.visible'); | ||
|
|
||
| getThumbnail(1) | ||
| .should('have.class', THUMBNAIL_SELECTED_CLASS) | ||
| .as('thumbOne'); | ||
|
|
||
| cy.getByTitle('Next page').click(); | ||
|
|
||
| getThumbnail(2).should('have.class', THUMBNAIL_SELECTED_CLASS); | ||
| cy.get('@thumbOne').should('not.have.class', THUMBNAIL_SELECTED_CLASS); | ||
| cy | ||
| .get('@currentPage') | ||
| .invoke('text') | ||
| .should('equal', '2'); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we stripping out data-testid like in elements?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we are, so this will get stripped out but html elements created via javascript won't. But when talking to @jstoffan this wasn't an issue because stripping these out is mainly to decrease bloat in the bundle.