Upgrade: Update pdf.js to v2.0.943 and closure compiler to v20190121 #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @jstoffan has signed the CLA. Thanks for the pull request! |
DanDeMicco
approved these changes
Feb 1, 2019
| @@ -508,28 +521,33 @@ export function loadScripts(urls, disableAMD = false) { | |||
| } | |||
|
|
|||
| urls.forEach((url) => { | |||
| if (!head.querySelector(`script[src="${url}"]`)) { | |||
| if (!promiseMap[url]) { | |||
There was a problem hiding this comment.
Would this function be cleaner as a map?
| @@ -13,6 +13,8 @@ const CLIENT_NAME = __NAME__; | |||
| export const CLIENT_VERSION = __VERSION__; | |||
| /* eslint-enable no-undef */ | |||
|
|
|||
| const promiseMap = {}; | |||
There was a problem hiding this comment.
Can you use an actual Map? This way you get built in methods such as clear for free (which you below)
| }); | ||
|
|
||
| return Promise.all(promises) | ||
| .then(() => { | ||
| if (disableAMD && amdPresent) { | ||
| define = defineRef; | ||
| } | ||
|
|
||
| clearPromises(); |
There was a problem hiding this comment.
can this go into a .finally?
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT
This changeset cannot currently be merged due to a blocking issue with font rendering in the latest version of pdf.js. We should continue to update this branch and test them against this issue as new versions are released.
Summary
This changeset is partially based on and supersedes #810. I've migrated our calls to pdf.js to match the associated API changes from 1.x -> 2.x. However, there is no official migration guide, so further manual testing on document variations will be required.
Known Issues
Warning: Failed to load font "g_d0_f2": SyntaxError: Invalid font data in ArrayBufferUncaught TypeError: Cannot read property 'div' of undefinedFeatures Tested