Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Emit thumbnails[Open|Close] viewer event #898

Merged

Conversation

ConradJChan
Copy link
Contributor

Emits new viewer events thumbnailsOpen and thumbnailsClose when the thumbnails sidebar is toggled opened and closed.

@boxcla
Copy link

boxcla commented Jan 22, 2019

Verified that @ConradJChan has signed the CLA. Thanks for the pull request!

@ConradJChan ConradJChan force-pushed the content-preview-integration branch from 43623c6 to df0b7de Compare January 22, 2019 21:26
Copy link
Contributor

@jeremypress jeremypress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ConradJChan ConradJChan merged commit f114030 into box:thumbnails-sidebar Jan 23, 2019
@ConradJChan ConradJChan deleted the content-preview-integration branch January 23, 2019 21:49
ConradJChan pushed a commit to ConradJChan/box-content-preview that referenced this pull request Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants