New: Thumbnails toggle button #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ConradJChan
commented
Dec 3, 2018
ConradJChan
commented
|
Verified that @ConradJChan has signed the CLA. Thanks for the pull request! |
|
It might be my eyes failing on me, but the new icon looks quite a bit brighter than the others. Was that meant to be its hovered state color? |
jeremypress
reviewed
Dec 3, 2018
| @@ -929,7 +937,26 @@ class DocBaseViewer extends BaseViewer { | |||
| * @protected | |||
There was a problem hiding this comment.
Remove Overridden from the doc string
jeremypress
reviewed
Dec 3, 2018
| @@ -929,7 +937,26 @@ class DocBaseViewer extends BaseViewer { | |||
| * @protected | |||
| * @return {void} | |||
| */ | |||
| bindControlListeners() {} | |||
| bindControlListeners() { | |||
There was a problem hiding this comment.
Makes me wonder why the controls logic was duplicated in the first place.
jeremypress
approved these changes
Dec 3, 2018
ConradJChan
pushed a commit
that referenced
this pull request
Dec 11, 2018
ConradJChan
pushed a commit
that referenced
this pull request
Feb 1, 2019
ConradJChan
pushed a commit
that referenced
this pull request
Feb 5, 2019
ConradJChan
pushed a commit
to ConradJChan/box-content-preview
that referenced
this pull request
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.