Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add test to check PDFjs headers to avoid preflight #855

Merged
merged 2 commits into from
Oct 25, 2018
Merged

Chore: Add test to check PDFjs headers to avoid preflight #855

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec8b3c0
Chore: Add test to check PDFjs headers to avoid preflight
Oct 25, 2018
e940643
Merge branch 'master' into Add-test-to-avoid-preflight-for-pdfjs
JustinHoldstock Oct 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions src/lib/viewers/doc/__tests__/DocBaseViewer-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,18 @@ let docBase;
let containerEl;
let stubs = {};

const STANDARD_HEADERS = [
'Accept',
'Accept-Language',
'Content-Language',
'Content-Type',
'DPR',
'Downlink',
'Save-Data',
'Viewport-Width',
'Width'
];

describe('src/lib/viewers/doc/DocBaseViewer', () => {
const setupFunc = BaseViewer.prototype.setup;

Expand Down Expand Up @@ -932,6 +944,29 @@ describe('src/lib/viewers/doc/DocBaseViewer', () => {
});
});

it('should avoid preflight requests by not adding non-standard headers', (done) => {
docBase.options.location = {
locale: 'en-US'
};
// Excluding IOS for If-None-Match cache busting
sandbox.stub(Browser, 'isIOS').returns(false);
sandbox.stub(PDFJS, 'getDocument').callsFake((docInitParams) => {
return new Promise(() => {
const { httpHeaders = {} } = docInitParams;
const headerKeys = Object.keys(httpHeaders);

const containsNonStandardHeader = headerKeys.some((header) => {
return !STANDARD_HEADERS.includes(header);
});

expect(containsNonStandardHeader).to.be.false;
done();
});
});

return docBase.initViewer('');
});

it('should append encoding query parameter for gzip content when range requests are disabled', () => {
// en-US allows for disabled range requests
docBase.options.location = {
Expand Down