Chore: Enable PDF signatures in future builds of PDF.js #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @jeremypress has signed the CLA. Thanks for the pull request! |
DanDeMicco
reviewed
Oct 23, 2018
build/upgrade_pdfjs.sh
Outdated
| echo "Enabling PDF signatures" | ||
| echo "-----------------------------------------------------------------------------------" | ||
| # Deletes a block of code that starts with `if (data.fieldType === 'Sig') {``, and ends with `}` | ||
| sed -e "/if (data.fieldType === 'Sig') {/,/}/d" -i '' src/third-party/doc/1.30.0/pdf.worker.js |
There was a problem hiding this comment.
Should you use DOC_STATIC_ASSETS_VERSION?
There was a problem hiding this comment.
yep, forgot to put it back after testing.
JustinHoldstock
approved these changes
Oct 23, 2018
|
Should we add some safeguards to this file to make it so if any of these modifications fails to do something, it fails the build? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.