Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Only reset to upstream/master for major/minor releases #745

Closed
wants to merge 3 commits into from

Conversation

pramodsum
Copy link
Contributor

@pramodsum pramodsum commented Mar 28, 2018

This will prevent patch releases from resetting to upstream/master. Instead, it will reset to the previous version of Preview (if available).

  • TODO: replicate the same logic in BoxAnnotations

@boxcla
Copy link

boxcla commented Mar 28, 2018

Verified that @pramodsum has signed the CLA. Thanks for the pull request!

build/release.sh Outdated
# Reset and fetch upstream with tags
reset_tags || return 1;

# Reset to latest code and clear unstashed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Reset to latest release"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants