New: timestamp unit for startAt #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @DanDeMicco has signed the CLA. Thanks for the pull request! |
jeremypress
approved these changes
Mar 1, 2018
| * @return {number} - the time in seconds | ||
| */ | ||
| convertTimestampToSeconds(timestamp) { | ||
| let timeInSeconds = 0; |
There was a problem hiding this comment.
use INITIAL_TIME_IN_SECOND?
| * @param {string} match - the timestamp substring e.g. 1h, 2m, or 3s | ||
| * @return {number} - the number for the given unit | ||
| */ | ||
| const getValueOfMatch = (match) => { |
There was a problem hiding this comment.
Might want to break this out for testing purposes
| return Number.isNaN(parsedMatch) ? 0 : parsedMatch; | ||
| }; | ||
|
|
||
| if (hours) { |
pramodsum
approved these changes
Mar 1, 2018
tonyjin
approved these changes
Mar 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for timestamp parsing for startAt. A timestamp is a youtube style timestamp such as 5h2m1s and will start media previews at that point.