Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Ensure only loading wrapper is interactable preview container #583

Merged
merged 5 commits into from
Jan 17, 2018
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lib/_loading.scss
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@
}
}

// Preview content should not be interactable during loading
:not(.bp-loaded) > .bp-loading-wrapper + div {
// Only the loading wrapper should be interactable inside the Preview container
.bp:not(.bp-loaded) > div:not(.bp-loading-wrapper) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we avoid 2 nots? Maybe add this to all and then nest for the .bp-loading-wrapper where we turn touch events back on.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pointer-events: none;
}

Expand Down