Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Removing rotateLeft method from DocBaseViewer #52

Merged
merged 1 commit into from
Apr 6, 2017
Merged

Chore: Removing rotateLeft method from DocBaseViewer #52

merged 1 commit into from
Apr 6, 2017

Conversation

pramodsum
Copy link
Contributor

@pramodsum pramodsum commented Apr 6, 2017 •
edited
Loading

We no longer support this function of the Document viewer

tonyjin
tonyjin approved these changes Apr 6, 2017
View reviewed changes
Copy link
Contributor

@tonyjin tonyjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd update the commit message to mention 'unused' - maybe Chore: Removing unused rotateLeft method from doc viewer

@pramodsum pramodsum merged commit 8bdd40b into box:master Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyjin tonyjin tonyjin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pramodsum @tonyjin @JustinHoldstock