Chore: only use source maps when running unit tests in debug mode #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @jeremypress has signed the CLA. Thanks for the pull request! |
jeremypress
commented
Nov 22, 2017
| @@ -1,19 +1,28 @@ | |||
| require('babel-polyfill'); | |||
|
|
|||
| const { argv } = process; | |||
There was a problem hiding this comment.
Looking for a better way to determine the original command to run the tests
There was a problem hiding this comment.
We do this in webpack.config.js, would it work here?
const isRelease = process.env.NODE_ENV === 'production';
const isDev = process.env.NODE_ENV === 'dev';
There was a problem hiding this comment.
That's a good catch to turn them off for prod, but we also want to turn them off if we're not running 'debug' in any environment. We never run debug during a production build so it should already be covered.
| resolve: { | ||
| alias: { | ||
| sinon: 'sinon/pkg/sinon' | ||
| } | ||
| } | ||
| }); | ||
|
|
||
| if (isDebug) { | ||
| config.devtool = 'inline-source-map'; |
There was a problem hiding this comment.
Will change this to the other source map type once I check it on all of our browsers
JustinHoldstock
approved these changes
Dec 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source maps don't work in phantom, so we should turn them off unless running our tests in debug mode in a browser. This should shave off between 30-45 seconds every place we run our tests; locally, jenkins, and travis.