Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix full screen overflow on Windows Chrome #491

Merged
merged 3 commits into from
Nov 20, 2017
Merged

Fix: fix full screen overflow on Windows Chrome #491

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e625ec
Fix: fix full screen overflow on Windows Chrome
Nov 16, 2017
5de64d2
Merge branch 'master' into fullscreen-windows-chrome
Nov 20, 2017
ad8220b
Merge branch 'master' into fullscreen-windows-chrome
Nov 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/lib/viewers/media/DashViewer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,9 +328,8 @@ class DashViewer extends VideoBaseViewer {
*/
shakaErrorHandler(shakaError) {
const error = new Error(
`Shaka error. Code = ${shakaError.detail.code}, Category = ${shakaError.detail.category}, Severity = ${
shakaError.detail.severity
}, Data = ${shakaError.detail.data.toString()}`
`Shaka error. Code = ${shakaError.detail.code}, Category = ${shakaError.detail
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier having fun here

.category}, Severity = ${shakaError.detail.severity}, Data = ${shakaError.detail.data.toString()}`
);
error.displayMessage = __('error_refresh');

Expand Down Expand Up @@ -492,7 +491,10 @@ class DashViewer extends VideoBaseViewer {
resize() {
let width = this.videoWidth || 0;
let height = this.videoHeight || 0;
const viewport = this.wrapperEl.getBoundingClientRect();
const viewport = {
height: this.wrapperEl.clientHeight,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like windows chrome was giving slightly larger values for getBoundingClientRect. I'll verify this with IE/Edge tomorrow.

Copy link
Contributor Author

@jeremypress jeremypress Nov 16, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows Chrome getBoundingClientRect values: {height: 1275.3333740234375 , width: 1665.3333740234375}
Element clientHeight and ClientWidth values: {height: 1275, width: 1665}

width: this.wrapperEl.clientWidth
};

// We need the width to be atleast wide enough for the controls
// to not overflow and fit properly
Expand Down