Chore: extract file loading icons to be used globally throughout preview #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremypress
commented
Nov 16, 2017
| case 'flv': | ||
| this.icon = ICON_FILE_MEDIA; | ||
| this.icon = getIconFromExtension(file.extension); |
There was a problem hiding this comment.
This is here to maintain current behavior. Eventually we can just rely on the setup on base viewer and then fall back if needed
JustinHoldstock
approved these changes
Nov 20, 2017
|
@JustinHoldstock I don't want to use extensions because that's used for determining which viewers we want to use. I'd like to keep it here for now and if our list expands greatly we can break it out. Thanks to @tonyjin on the map adding one liners |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.