Chore: Adding console errors for annotation errors

src/lib/annotations/AnnotationService.js

@@ -117,10 +117,11 @@ class AnnotationService extends EventEmitter {
                     }
                 })
                 /* istanbul ignore next */
-                .catch(() => {
+                .catch((error) => {
                     reject(new Error('Could not create annotation due to invalid or expired token'));
                     this.emit('annotationerror', {
-                        reason: 'authorization'
+                        reason: 'authorization',
+                        error
                     });
                 });
         });
@@ -168,10 +169,11 @@ class AnnotationService extends EventEmitter {
                     }
                 })
                 /* istanbul ignore next */
-                .catch(() => {
+                .catch((error) => {
                     reject(new Error('Could not delete annotation due to invalid or expired token'));
                     this.emit('annotationerror', {
-                        reason: 'authorization'
+                        reason: 'authorization',
+                        error
                     });
                 });
         });
@@ -303,10 +305,11 @@ class AnnotationService extends EventEmitter {
                     }
                 }
             })
-            .catch(() => {
+            .catch((error) => {
                 reject(new Error('Could not read annotations from file due to invalid or expired token'));
                 this.emit('annotationerror', {
-                    reason: 'authorization'
+                    reason: 'authorization',
+                    error
                 });
             });
     }

src/lib/annotations/AnnotationThread.js

@@ -158,7 +158,7 @@ class AnnotationThread extends EventEmitter {
         return this.annotationService
             .create(annotationData)
             .then((savedAnnotation) => this.updateTemporaryAnnotation(tempAnnotation, savedAnnotation))
-            .catch(() => this.handleThreadSaveError(tempAnnotationID));
+            .catch((error) => this.handleThreadSaveError(error, tempAnnotationID));
     }
 
     /**
@@ -171,9 +171,23 @@ class AnnotationThread extends EventEmitter {
     deleteAnnotation(annotationID, useServer = true) {
         // Ignore if no corresponding annotation exists in thread or user doesn't have permissions
         const annotation = this.annotations.find((annot) => annot.annotationID === annotationID);
-        if (!annotation || (annotation.permissions && !annotation.permissions.can_delete)) {
+        if (!annotation) {
             // Broadcast error
             this.emit(THREAD_EVENT.deleteError);
+            console.error(
+                THREAD_EVENT.deleteError,
+                `Annotation with ID ${annotation.threadNumber} could not be found.`
+            );
+            return Promise.reject();
+        }
+
+        if (annotation.permissions && !annotation.permissions.can_delete) {
+            // Broadcast error
+            this.emit(THREAD_EVENT.deleteError);
+            console.error(
+                THREAD_EVENT.deleteError,
+                `User does not have the correct permissions to delete annotation with ID ${annotation.threadNumber}.`
+            );
             return Promise.reject();
         }
 
@@ -203,6 +217,10 @@ class AnnotationThread extends EventEmitter {
         }
 
         if (!useServer) {
+            console.error(
+                THREAD_EVENT.deleteError,
+                `Annotation with ID ${annotation.threadNumber} not deleted from server`
+            );
             return Promise.resolve();
         }
 
@@ -228,9 +246,10 @@ class AnnotationThread extends EventEmitter {
                 // Broadcast annotation deletion event
                 this.emit(THREAD_EVENT.delete);
             })
-            .catch(() => {
+            .catch((error) => {
                 // Broadcast error
                 this.emit(THREAD_EVENT.deleteError);
+                console.error(THREAD_EVENT.deleteError, error.toString());
             });
     }
 
@@ -588,15 +607,17 @@ class AnnotationThread extends EventEmitter {
      * Deletes the temporary annotation if the annotation failed to save on the server
      *
      * @private
+     * @param {error} error - error thrown while saving the annotation
      * @param {string} tempAnnotationID - ID of temporary annotation to be updated with annotation from server
      * @return {void}
      */
-    handleThreadSaveError(tempAnnotationID) {
+    handleThreadSaveError(error, tempAnnotationID) {
         // Remove temporary annotation
         this.deleteAnnotation(tempAnnotationID, /* useServer */ false);
 
         // Broadcast error
         this.emit(THREAD_EVENT.createError);
+        console.error(THREAD_EVENT.createError, error.toString());
     }
 
     /**

src/lib/annotations/Annotator.js

@@ -652,6 +652,10 @@ class Annotator extends EventEmitter {
             default:
         }
 
+        if (data.error) {
+            console.error(ANNOTATOR_EVENT.error, data.error.toString());
+        }
+
         if (errorMessage) {
             this.emit(ANNOTATOR_EVENT.error, errorMessage);
         }
@@ -935,6 +939,7 @@ class Annotator extends EventEmitter {
         }
 
         this.emit(ANNOTATOR_EVENT.error, __('annotations_load_error'));
+        console.error('Annotation could not be created due to invalid params');
         this.validationErrorEmitted = true;
     }
 

src/lib/annotations/doc/DocAnnotator.js

@@ -463,6 +463,7 @@ class DocAnnotator extends Annotator {
         const highlightThreads = this.getHighlightThreadsOnPage(pageNum);
         highlightThreads.forEach((thread) => {
             if (annotatorUtil.isPending(thread.state)) {
+                console.error('Pending annotation thread destroyed', thread.threadNumber);
                 thread.destroy();
             }
         });
@@ -861,20 +862,17 @@ class DocAnnotator extends Annotator {
 
         // Select page of first node selected
         const { pageEl } = annotatorUtil.getPageInfo(selection.anchorNode);
-
         if (!pageEl) {
             return;
         }
 
         const lastRange = selection.getRangeAt(selection.rangeCount - 1);
         const rects = lastRange.getClientRects();
-
         if (rects.length === 0) {
             return;
         }
 
         const { right, bottom } = rects[rects.length - 1];
-
         const pageDimensions = pageEl.getBoundingClientRect();
         const pageLeft = pageDimensions.left;
         const pageTop = pageDimensions.top + PAGE_PADDING_TOP;

src/lib/util.js

@@ -155,7 +155,9 @@ export function get(url, ...rest) {
             break;
     }
 
-    return fetch(url, { headers }).then(checkStatus).then(parser);
+    return fetch(url, { headers })
+        .then(checkStatus)
+        .then(parser);
 }
 
 /**

src/lib/viewers/BaseViewer.js

@@ -346,7 +346,9 @@ class BaseViewer extends EventEmitter {
             }
 
             if (this.annotationsPromise) {
-                this.annotationsPromise.then(this.loadAnnotator);
+                this.annotationsPromise.then(this.loadAnnotator).catch((error) => {
+                    console.error('Annotation assets failed to load', error.toString());
+                });
             }
         });
     }