New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: annotation mode exits on wrong button and fetch annotations returns non-promise #363

Merged

Minh-Ng merged 2 commits into box:master from Minh-Ng:master

Sep 3, 2017

Contributor

Minh-Ng commented Sep 2, 2017

Annotation mode exits using the wrong button element. This causes the wrong one to become in-active
When calling fetchannotations() without permissions to view all or own annotations, a non-promise unexpectedly returned.

Minh Nguyen added 2 commits

September 2, 2017 16:16


          Fix: return promise

b786555


          Fix: disable modes except

89059ee

pramodsum reviewed

View reviewed changes

src/lib/annotations/Annotator.js

@@ @@ -543,7 +545,7 @@ class Annotator extends EventEmitter { @@
                       // Do not load any pre-existing annotations if the user does not have
                       // the correct permissions
                       if (!this.permissions.canViewAllAnnotations || !this.permissions.canViewOwnAnnotations) {
-                          return this.threads;

Contributor

pramodsum Sep 2, 2017

oh shoot. Great catch! Thanks!

pramodsum approved these changes

View reviewed changes

Minh-Ng merged commit aed6288 into box:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet