Update: Allow passed in collections to be of file objects #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyajeet
force-pushed
the
master
branch
4 times, most recently
from
8e6feba to
cdc691e
Compare
Also allows tokens to be null or undefined. Useful when the passed in file or collection has well formed file objects. Also changes the token getter to pass in typed ids for files and handle cases when typed ids are returned from the token service to make it consistant with other UI Elements. Since all the UI elements can either be requesting folder or file ids, the token service needs to know what type of id we are sending it, as such either file_ or folder_ is prefixed to all the ids. Likewise the token service will return typed ids after fetching tokens.
JustinHoldstock
approved these changes
Sep 12, 2017
| this.previewOptions = Object.assign({}, options, { token }); | ||
| } else { | ||
| throw new Error('Missing access token!'); | ||
| throw new Error('Bad access token!'); |
There was a problem hiding this comment.
Should this be a translated string?
| fileIds.push(fileOrId.id); | ||
| files.push(fileOrId); | ||
| } else { | ||
| throw new Error('Bad collection provided!'); |
There was a problem hiding this comment.
Translated string?
| @@ -1,19 +1,46 @@ | |||
| // Create an error to throw if needed | |||
| const error = new Error('Missing Auth Token!'); | |||
| const error = new Error('Bad Auth Token!'); | |||
There was a problem hiding this comment.
Another translated string
There was a problem hiding this comment.
Also, I can't say I've ever seen anyone reuse an Error Object. Should there be any gotchas with that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows tokens to be null or undefined. Useful when the passed in file or collection has well formed file objects. This is for offline use case or the use case where the parent project (like ContentExplorer UI Element) has already made the call.
Also changes the token getter to pass in typed ids for files and handle cases when typed ids are returned from the token service to make it consistent with other UI Elements. Since all the UI elements can either be requesting
folderorfileids, the token service needs to know what type of id we are sending it, as such eitherfile_orfolder_is prefixed to all the ids. Likewise the token service can/will return typed ids after fetching tokens. So it needs to be mapped back to what preview wants.