Chore: Cleaning up annotations methods in BaseViewer #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/lib/viewers/BaseViewer.js
Outdated
| return; | ||
| } | ||
| showModeAnnotationButton(currentMode) { | ||
| const modes = { |
There was a problem hiding this comment.
Move this out to a higher level constant. Doesn't need to be created every time we call this method
There was a problem hiding this comment.
moved this one level higher
pramodsum
force-pushed
the
refactor_annotations
branch
from
806c8a7 to
039a75c
Compare
pramodsum
force-pushed
the
refactor_annotations
branch
from
039a75c to
dde7a57
Compare
pramodsum
force-pushed
the
refactor_annotations
branch
from
dde7a57 to
2468a37
Compare
JustinHoldstock
approved these changes
Aug 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do NOT merge before #271