Fix: Increase controls timeout and fix controls behavior for mobile VR #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremypress
commented
Jul 20, 2017
| @@ -6,7 +6,7 @@ const SHOW_PREVIEW_CONTROLS_CLASS = 'box-show-preview-controls'; | |||
| const CONTROLS_BUTTON_CLASS = 'bp-controls-btn'; | |||
| const CONTROLS_PAGE_NUM_INPUT_CLASS = 'bp-doc-page-num-input'; | |||
| const CONTROLS_PAGE_NUM_WRAPPER_CLASS = 'bp-doc-page-num-wrapper'; | |||
| const CONTROLS_AUTO_HIDE_TIMEOUT_IN_MILLIS = 1500; | |||
| const CONTROLS_AUTO_HIDE_TIMEOUT_IN_MILLIS = 2000; | |||
There was a problem hiding this comment.
As requested by Zach
| /* stylelint-disable declaration-no-important */ | ||
| opacity: 1 !important; | ||
| /* stylelint-enable declaration-no-important */ | ||
| z-index: 1; |
There was a problem hiding this comment.
@JustinHoldstock any issues with using z-index: 1? Moving this block above the vr-enabled override fixes the first issue.
There was a problem hiding this comment.
AFAIK this should be gouda!
pramodsum
approved these changes
Jul 21, 2017
JustinHoldstock
approved these changes
Jul 24, 2017
| /* stylelint-disable declaration-no-important */ | ||
| opacity: 1 !important; | ||
| /* stylelint-enable declaration-no-important */ | ||
| z-index: 1; |
There was a problem hiding this comment.
AFAIK this should be gouda!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.