Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Allow panning on mobile while zooming into ppt files #192

Merged
merged 4 commits into from
Jul 5, 2017
Merged

Fix: Allow panning on mobile while zooming into ppt files #192

merged 4 commits into from
Jul 5, 2017

Conversation

jeremypress
Copy link
Contributor

No description provided.

JustinHoldstock
JustinHoldstock approved these changes Jul 5, 2017
View reviewed changes
Copy link
Contributor

@JustinHoldstock JustinHoldstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea separating isMobile and hasTouch

@jeremypress jeremypress merged commit 68091e3 into box:master Jul 5, 2017
@jeremypress jeremypress deleted the mobile-ppt-zoom-scroll branch July 5, 2017 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinHoldstock JustinHoldstock JustinHoldstock approved these changes

@pramodsum pramodsum Awaiting requested review from pramodsum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremypress @JustinHoldstock