Fix: Fix focus for new page number input #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremypress
requested review from
tonyjin,
pramodsum and
JustinHoldstock
and removed request for
tonyjin
tonyjin
reviewed
Jun 28, 2017
| * | ||
| * @property {boolean} | ||
| */ | ||
| hasTouch = Browser.hasTouch(); |
There was a problem hiding this comment.
So doing this might mean this check is performed when this class is defined, not when it's initialized (I'm not super clear on this). Given we have a context loss handler this may be okay, just FYI.
There was a problem hiding this comment.
It should only be doing the touch check which doesn't use webGL.
There was a problem hiding this comment.
Doh! Saw Browser and assumed webGL for some reason.
tonyjin
approved these changes
Jun 28, 2017
| this.containerEl = container; | ||
|
|
||
| this.controlsWrapperEl = this.containerEl.appendChild(document.createElement('div')); | ||
| this.controlsWrapperEl.className = 'bp-controls-wrapper'; | ||
| const controlsWrapperEl = this.containerEl.appendChild(document.createElement('div')); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parent of the input element is now the page-num-wrapper and not a bp-control-button