fix(pdf): fix for blurry/pixelated images #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
karelee7
previously approved these changes
Jan 24, 2023
jstoffan
reviewed
Jan 24, 2023
|
@bfoxx1906, can you add some comments in the diff to explain what the actual change was? Do we plan to add a |
|
@bfoxx1906, did we update |
karelee7
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Altering pdf.js to ignore image interpolation values set to false. This was causing images to show up blurry. This code in question was added in this PR . The change is in the method getImageSmoothingEnabled in pdf.js. Additionally, I added a new version of pdf.js(2.90.0) in the third party directory to match this upgraded version of preview.