feat(docuworks): Add support for docuworks file types #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ConradJChan
commented
Mar 23, 2022
•
ConradJChan
commented
jstoffan
reviewed
Mar 23, 2022
jstoffan
approved these changes
Mar 24, 2022
| @@ -1,6 +1,6 @@ | |||
| import React from 'react'; | |||
| import ReactDOM from 'react-dom'; | |||
| import Grid from 'react-virtualized/dist/es/Grid/Grid'; | |||
| import { Grid } from '@box/react-virtualized/dist/es/Grid'; | |||
There was a problem hiding this comment.
Do we need the object notation? It looks like the Grid barrel file re-exports Grid as its default.
There was a problem hiding this comment.
Yeah I tried without and the unit tests failed, I think because of the jest mapping to the commonjs directory might not have the same exports
karelee7
pushed a commit
to jstoffan/box-content-preview
that referenced
this pull request
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.