Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pdfjs): Use allowlist for exporting font data #1414

Merged
merged 4 commits into from
Jul 29, 2021

Conversation

ConradJChan
Copy link
Contributor

@ConradJChan ConradJChan commented Jul 29, 2021

Applying the fix found here: mozilla/pdf.js#13771

Fixes the issue where PDF files using Courier font (could possibly apply to others as well) were copying properties that were incompatible with cloning between the pdf.js in the main thread and pdf.worker.js in the WebWorker by only copying properties found in an allow list

TODO:

  • cross-browser testing

@ConradJChan ConradJChan requested a review from a team as a code owner July 29, 2021 00:38
jstoffan
jstoffan previously approved these changes Jul 29, 2021
src/lib/constants.js Outdated Show resolved Hide resolved
src/third-party/doc/2.76.0/pdf.worker.js Show resolved Hide resolved
jstoffan
jstoffan previously approved these changes Jul 29, 2021
jstoffan
jstoffan previously approved these changes Jul 29, 2021
Copy link
Collaborator

@jstoffan jstoffan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update our upgrade_pdfjs script with this change?

src/third-party/doc/2.76.0/pdf.worker.js Show resolved Hide resolved
src/third-party/doc/2.76.0/pdf.worker.js Show resolved Hide resolved
@ConradJChan ConradJChan merged commit 8dea22e into box:master Jul 29, 2021
@ConradJChan ConradJChan deleted the fix-pdfjs-clone branch July 29, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants