Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dash): Add react version of filmstrip controls #1408

Merged
merged 1 commit into from
Jul 16, 2021
Merged

feat(dash): Add react version of filmstrip controls #1408

merged 1 commit into from
Jul 16, 2021

Conversation

jstoffan
Copy link
Collaborator

@jstoffan jstoffan commented Jul 7, 2021 •
edited
Loading

Todo

  • Break out slider changes
  • Cross-browser testing
  • Unit tests

Depends on #1410.

@jstoffan jstoffan force-pushed the react-ui-filmstrip branch 4 times, most recently from 22e7199 to 5a5b289 Compare July 16, 2021 21:15
@jstoffan jstoffan marked this pull request as ready for review July 16, 2021 21:16
@jstoffan jstoffan requested a review from a team as a code owner July 16, 2021 21:16
ConradJChan
ConradJChan reviewed Jul 16, 2021
View reviewed changes
src/lib/viewers/controls/media/Filmstrip.tsx Outdated Show resolved Hide resolved
src/lib/viewers/controls/media/Filmstrip.scss Show resolved Hide resolved
src/lib/viewers/controls/media/Filmstrip.scss Outdated Show resolved Hide resolved
src/lib/viewers/controls/media/TimeControls.tsx Outdated Show resolved Hide resolved
src/lib/viewers/media/DashViewer.js Show resolved Hide resolved
ConradJChan
ConradJChan previously approved these changes Jul 16, 2021
View reviewed changes
@jstoffan jstoffan force-pushed the react-ui-filmstrip branch from da151c0 to 485c96f Compare July 16, 2021 22:16
@mergify mergify bot merged commit 7fc29a3 into box:master Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConradJChan ConradJChan ConradJChan approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jstoffan @ConradJChan