feat(controls): Add Settings menu to Model3D

[ConradJChan]

TODO:

• Unit tests
• Cross-browser testing

Before:

After:

[jstoffan]

LGTM overall, nice job.

[jstoffan]

It seems like any call to Model3dViewer's renderUI would reset the controls, since the handler is declared as an inline function. Is that not the case? Would it be safer to create a useCallback helper that can both call setIsOpen and onClose or onOpen?

[ConradJChan]

No, that's not the case. Seems like any call to renderUI should probably create a new callback for resetControls but not necessarily call it

[ConradJChan]

Are you proposing something like:

const setIsOpenHelper = React.useCallback(() => {
    const nextIsOpen = !isOpen;
    setIsOpen(nextIsOpen);

    if (nextIsOpen) {
        onOpen();
    } else {
        onClose();
    }
}, [onClose, onOpen]);

And use that in place of setIsOpen?

[jstoffan]

Does this affect the media controls at all?

[ConradJChan]

No this is an override only for SettingsDropdown