feat(loading): Show ghost state for document preloaders and pages #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstoffan
force-pushed
the
preview-loading-preloader
branch
3 times, most recently
from
6ad1dde to
ffac1ba
Compare
|
Is there a gif of the new effect? |
ConradJChan
reviewed
Apr 8, 2021
jstoffan
force-pushed
the
preview-loading-preloader
branch
from
ffac1ba to
ac4eb90
Compare
jstoffan
force-pushed
the
preview-loading-preloader
branch
from
ac4eb90 to
d631e20
Compare
|
I'm not sure what's going on with this branch/build, since I'm not able to recreate the end-to-end test failure locally. Going to try a new branch/PR to see if it's a caching issue in Travis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces the pulsing three blue bar crawler with a "shine" ghost state effect.