Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): Add meaningful alt text to custom logo #1352

Merged
merged 4 commits into from
Apr 15, 2021
Merged

fix(a11y): Add meaningful alt text to custom logo #1352

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3caf809
fix(custom_logo): Adds missing alt attribute to custom-logo element
tille Apr 8, 2021
2762678
fix(custom_logo): Internationalize alternative image text
tille Apr 9, 2021
37c8019
fix(a11y): Adress PR comments
tille Apr 14, 2021
aaed36c
fix(a11y): Adress PR comments
tille Apr 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/shell.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
></path>
</svg>
</span>
<img class="bp-is-hidden bp-custom-logo" />
<img class="bp-is-hidden bp-custom-logo" alt="logo" />
tille marked this conversation as resolved.
Show resolved Hide resolved
<div class="bp-header-btns">
<button
class="bp-btn-plain bp-btn-annotate-draw bp-is-hidden"
Expand Down