Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DocFindBar): Add aria-label to docfindbar input field #1350

Merged
merged 4 commits into from
Apr 7, 2021
Merged

fix(DocFindBar): Add aria-label to docfindbar input field #1350

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
74e9c5f
fix: add aria-label to docfindbar input field
fsuarez-globant Apr 7, 2021
f40856c
fix: add string in internationalization file
fsuarez-globant Apr 7, 2021
ae8f911
fix: change internationalization key
fsuarez-globant Apr 7, 2021
682c679
Merge branch 'master' into a11y-missing-form-label-preview
fsuarez-globant Apr 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/i18n/en-US.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ find_next=Find next
find_previous=Find previous
# Button tooltip for closing the find bar
find_close=Close
# Search input Aria-label attribute
search_input=Search input
jstoffan marked this conversation as resolved.
Show resolved Hide resolved

# Error messages
# Default preview error message
Expand Down
2 changes: 1 addition & 1 deletion src/lib/viewers/doc/DocFindBar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ class DocFindBar extends EventEmitter {
// Find input field
this.findFieldEl = document.createElement('input');
this.findFieldEl.classList.add('bp-doc-find-field');
this.findFieldEl.setAttribute('aria-label', 'Search input');
this.findFieldEl.setAttribute('aria-label', __('search_input'));
this.findBarEl.appendChild(this.findFieldEl);

// Match Results Count
Expand Down