Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(controls): Hide find and thumbnail toggles if options are disabled #1311

Merged
merged 1 commit into from
Jan 4, 2021
Merged

fix(controls): Hide find and thumbnail toggles if options are disabled #1311

merged 1 commit into from
Jan 4, 2021

Conversation

jstoffan
Copy link
Collaborator

I chose to short-circuit the toggles if their callback is undefined to avoid further prop sprawl on the DocControls component.

@jstoffan jstoffan requested a review from a team as a code owner December 24, 2020 02:14
@jstoffan jstoffan merged commit 46df6e4 into box:master Jan 4, 2021
@jstoffan jstoffan deleted the react-ui-options branch January 4, 2021 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConradJChan ConradJChan ConradJChan approved these changes

@mxiao6 mxiao6 mxiao6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jstoffan @mxiao6 @ConradJChan