feat(controls): Add react versions of existing media control icons #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConradJChan
approved these changes
Dec 3, 2020
| function IconVolumeLow24(props: React.SVGProps<SVGSVGElement>): JSX.Element { | ||
| return ( | ||
| <svg focusable={false} height={24} viewBox="-3 5 24 24" width={24} {...props}> | ||
| <path d="M0 14v6h4l5 5V9l-5 5H0z" fill="#FFF" /> |
There was a problem hiding this comment.
Should these #fff and #FFF be consistent?
There was a problem hiding this comment.
The other icons are already inconsistent. I can do this separately if it's important?
There was a problem hiding this comment.
Should we be using the buie $white color?
|
|
||
| function IconVolumeLow24(props: React.SVGProps<SVGSVGElement>): JSX.Element { | ||
| return ( | ||
| <svg focusable={false} height={24} viewBox="-3 5 24 24" width={24} {...props}> |
There was a problem hiding this comment.
Are these negative values in the viewBox worrisome?
There was a problem hiding this comment.
The SVGs are copied directly from the existing icons. I'd rather not mess with them much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.