-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(controls): Add react versions of findbar and sidebar controls #1288
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
@import '../styles'; | ||
|
||
.bp-FindBarToggle { | ||
@include bp-ControlButton; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
import React from 'react'; | ||
import IconSearch18 from '../icons/IconSearch18'; | ||
import './FindBarToggle.scss'; | ||
|
||
export type Props = { | ||
onFindBarToggle: () => void; | ||
}; | ||
|
||
export default function FindBarToggle({ onFindBarToggle }: Props): JSX.Element { | ||
return ( | ||
<button className="bp-FindBarToggle" onClick={onFindBarToggle} title={__('toggle_findbar')} type="button"> | ||
<IconSearch18 /> | ||
</button> | ||
); | ||
} |
29 changes: 29 additions & 0 deletions
29
src/lib/viewers/controls/findbar/__tests__/FindBarToggle-test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
import React from 'react'; | ||
import { shallow, ShallowWrapper } from 'enzyme'; | ||
import FindBarToggle from '../FindBarToggle'; | ||
import IconSearch18 from '../../icons/IconSearch18'; | ||
|
||
describe('FindBarToggle', () => { | ||
const getWrapper = (props = {}): ShallowWrapper => | ||
shallow(<FindBarToggle onFindBarToggle={jest.fn()} {...props} />); | ||
|
||
describe('event handlers', () => { | ||
test('should forward the click from the button', () => { | ||
const onToggle = jest.fn(); | ||
const wrapper = getWrapper({ onFindBarToggle: onToggle }); | ||
|
||
wrapper.simulate('click'); | ||
|
||
expect(onToggle).toBeCalled(); | ||
}); | ||
}); | ||
|
||
describe('render', () => { | ||
test('should return a valid wrapper', () => { | ||
const wrapper = getWrapper(); | ||
|
||
expect(wrapper.hasClass('bp-FindBarToggle')).toBe(true); | ||
expect(wrapper.exists(IconSearch18)).toBe(true); | ||
}); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
export * from './FindBarToggle'; | ||
export { default } from './FindBarToggle'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
@import '../styles'; | ||
|
||
.bp-ThumbnailsToggle { | ||
@include bp-ControlButton; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import React from 'react'; | ||
import IconThumbnailsToggle18 from '../icons/IconThumbnailsToggle18'; | ||
import './ThumbnailsToggle.scss'; | ||
|
||
export type Props = { | ||
onThumbnailsToggle: () => void; | ||
}; | ||
|
||
export default function ThumbnailsToggle({ onThumbnailsToggle }: Props): JSX.Element { | ||
return ( | ||
<button | ||
className="bp-ThumbnailsToggle" | ||
onClick={onThumbnailsToggle} | ||
title={__('toggle_thumbnails')} | ||
type="button" | ||
> | ||
<IconThumbnailsToggle18 /> | ||
</button> | ||
); | ||
} |
29 changes: 29 additions & 0 deletions
29
src/lib/viewers/controls/sidebar/__tests__/ThumbnailsToggle-test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
import React from 'react'; | ||
import { shallow, ShallowWrapper } from 'enzyme'; | ||
import IconThumbnailsToggle18 from '../../icons/IconThumbnailsToggle18'; | ||
import ThumbnailsToggle from '../ThumbnailsToggle'; | ||
|
||
describe('ThumbnailsToggle', () => { | ||
const getWrapper = (props = {}): ShallowWrapper => | ||
shallow(<ThumbnailsToggle onThumbnailsToggle={jest.fn()} {...props} />); | ||
|
||
describe('event handlers', () => { | ||
test('should forward the click from the button', () => { | ||
const onToggle = jest.fn(); | ||
const wrapper = getWrapper({ onThumbnailsToggle: onToggle }); | ||
|
||
wrapper.simulate('click'); | ||
|
||
expect(onToggle).toBeCalled(); | ||
}); | ||
}); | ||
|
||
describe('render', () => { | ||
test('should return a valid wrapper', () => { | ||
const wrapper = getWrapper(); | ||
|
||
expect(wrapper.hasClass('bp-ThumbnailsToggle')).toBe(true); | ||
expect(wrapper.exists(IconThumbnailsToggle18)).toBe(true); | ||
}); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
export * from './ThumbnailsToggle'; | ||
export { default } from './ThumbnailsToggle'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
import React from 'react'; | ||
import ControlsBar from '../controls/controls-bar'; | ||
import FindBarToggle, { Props as FindBarToggleProps } from '../controls/findbar'; | ||
import FullscreenToggle, { Props as FullscreenToggleProps } from '../controls/fullscreen'; | ||
import ThumbnailsToggle, { Props as ThumbnailsToggleProps } from '../controls/sidebar'; | ||
import ZoomControls, { Props as ZoomControlsProps } from '../controls/zoom'; | ||
|
||
export type Props = FindBarToggleProps & FullscreenToggleProps & ThumbnailsToggleProps & ZoomControlsProps; | ||
|
||
export default function DocControls({ | ||
maxScale, | ||
minScale, | ||
onFindBarToggle, | ||
onFullscreenToggle, | ||
onThumbnailsToggle, | ||
onZoomIn, | ||
onZoomOut, | ||
scale, | ||
}: Props): JSX.Element { | ||
return ( | ||
<ControlsBar> | ||
<ThumbnailsToggle onThumbnailsToggle={onThumbnailsToggle} /> | ||
<FindBarToggle onFindBarToggle={onFindBarToggle} /> | ||
<ZoomControls | ||
maxScale={maxScale} | ||
minScale={minScale} | ||
onZoomIn={onZoomIn} | ||
onZoomOut={onZoomOut} | ||
scale={scale} | ||
/> | ||
<FullscreenToggle onFullscreenToggle={onFullscreenToggle} /> | ||
</ControlsBar> | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the onFindBarToggle too repetitive? How about onToggle?