Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(discoverability): add getInitialAnnotationMode override #1273

Merged
merged 2 commits into from
Oct 21, 2020
Merged

fix(discoverability): add getInitialAnnotationMode override #1273

merged 2 commits into from
Oct 21, 2020

Conversation

ChenCodes
Copy link
Contributor

Changes in this PR:

  • add getInitialAnnotationMode override in ImageViewer.js
  • add unit test

mxiao6
mxiao6 previously approved these changes Oct 21, 2020
View reviewed changes
src/lib/viewers/image/__tests__/ImageViewer-test.js Outdated Show resolved Hide resolved
ConradJChan
ConradJChan previously approved these changes Oct 21, 2020
View reviewed changes
@ChenCodes ChenCodes dismissed stale reviews from ConradJChan and mxiao6 via 9c7ae3f October 21, 2020 17:09
@ChenCodes ChenCodes marked this pull request as ready for review October 21, 2020 17:12
@ChenCodes ChenCodes requested a review from a team as a code owner October 21, 2020 17:12
@ChenCodes ChenCodes merged commit b64d8fc into box:master Oct 21, 2020
@ChenCodes ChenCodes deleted the fix-create-region-on-image-load branch October 21, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConradJChan ConradJChan ConradJChan approved these changes

@mxiao6 mxiao6 mxiao6 left review comments

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChenCodes @mxiao6 @ConradJChan