feat(discoverability): add class to bp-content if FF is enabled #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxiao6
reviewed
Sep 15, 2020
ConradJChan
reviewed
Sep 15, 2020
ChenCodes
commented
Sep 16, 2020
ChenCodes
commented
Sep 16, 2020
ChenCodes
commented
Sep 16, 2020
ChenCodes
commented
Sep 16, 2020
ConradJChan
reviewed
Sep 16, 2020
mxiao6
reviewed
Sep 16, 2020
mxiao6
reviewed
Sep 16, 2020
ConradJChan
reviewed
Sep 16, 2020
ConradJChan
reviewed
Sep 16, 2020
| add: sandbox.stub(), | ||
| remove: sandbox.stub(), | ||
| }, | ||
| removeEventListener: sandbox.stub(), |
There was a problem hiding this comment.
Is removeEventListener needed?
There was a problem hiding this comment.
Yeah it looks like it's needed as this error shows up if I remove that line:
undefined is not a constructor (evaluating 'this.containerEl.removeEventListener('contextmenu', this.preventDefault)')
ConradJChan
reviewed
Sep 16, 2020
ConradJChan
reviewed
Sep 16, 2020
mxiao6
reviewed
Sep 17, 2020
ChenCodes
changed the title
ConradJChan
previously approved these changes
Sep 17, 2020
mxiao6
previously approved these changes
Sep 17, 2020
mxiao6
approved these changes
Sep 17, 2020
ConradJChan
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bp-annotatons-discoverabletobp-contentif FF is enabled insetupmethodbp-annotations-create--regiontobp-contentif FF is enabled and mode was explicitly changed toREGIONbp-annotations-create--regionfrombp-contentif FF is enabled and mode was changed to anything other thanREGION