Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(annotations): Add Highlight Text button in toolbar #1236

Merged
merged 4 commits into from
Jul 27, 2020
Merged

feat(annotations): Add Highlight Text button in toolbar #1236

merged 4 commits into from
Jul 27, 2020

Conversation

mxiao6
Copy link
Contributor

@mxiao6 mxiao6 commented Jul 24, 2020 •
edited
Loading

  • Add tests

image

@mxiao6 mxiao6 requested a review from a team as a code owner July 24, 2020 22:53
@mxiao6 mxiao6 marked this pull request as draft July 24, 2020 22:53
jstoffan
jstoffan reviewed Jul 24, 2020
View reviewed changes
Copy link
Collaborator

@jstoffan jstoffan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Direction looks good to me.

src/i18n/en-US.properties Outdated Show resolved Hide resolved
src/lib/AnnotationControls.scss Outdated Show resolved Hide resolved
src/lib/AnnotationControls.ts Outdated Show resolved Hide resolved
@mxiao6 mxiao6 marked this pull request as ready for review July 27, 2020 17:04
@mxiao6 mxiao6 requested a review from ChenCodes July 27, 2020 17:37
@mxiao6 mxiao6 removed the request for review from ChenCodes July 27, 2020 18:34
@mergify mergify bot merged commit c0869fe into box:master Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstoffan jstoffan jstoffan approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxiao6 @jstoffan