New: Preload for presentation viewer #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tonyjin
commented
Mar 23, 2017
tonyjin
commented
- Moving show/hide preload functions to DocBase
- Moving loading icon for documents/presentations to base directory in output
- Separate styles for document and presentation preload
priyajeet
suggested changes
Mar 23, 2017
| @@ -62,7 +62,7 @@ module.exports = (language) => { | |||
| test: /\.(jpe?g|png|gif|woff2|woff)$/, | |||
| loader: 'file-loader', | |||
| options: { | |||
| name: '[path][name].[ext]' | |||
| name: '[name].[ext]' | |||
There was a problem hiding this comment.
Make sure images are not being created/repeated per locale.
It should be at a higher level so that all locales use the same image.
There was a problem hiding this comment.
Like we discussed, this image is small and was already placed in the locale repos previously.
- Moving show/hide preload functions to DocBase - Moving loading icon for documents/presentations to base directory in output - Separate styles for document and presentation preload - Add simple validation logic for reading EXIF from preload image - Don't preload or prefetch if file is watermarked
jeremypress
approved these changes
Mar 24, 2017
| */ | ||
| hidePreload() { | ||
| this.docPreloader.hidePreload(); | ||
| this.preloader.removeAllListeners('preload'); |
There was a problem hiding this comment.
are we planning on adding more listeners?
There was a problem hiding this comment.
Not for now - if we do it'll make sense to break it out into a separate function.
priyajeet
approved these changes
Mar 24, 2017
benjamin-shen
pushed a commit
to benjamin-shen/box-content-preview
that referenced
this pull request
Jun 29, 2022
Uploading works?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.