Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(archive): Add resin to ArchiveViewer #1134

Merged
merged 4 commits into from
Dec 27, 2019
Merged

Conversation

mxiao6
Copy link
Contributor

@mxiao6 mxiao6 commented Dec 23, 2019

The tests are failing because BUIE 11.1.0-beta.27 (contains renderers dataAttributes change) is not available until Monday 6pm.

@mxiao6 mxiao6 requested a review from a team as a code owner December 23, 2019 18:16
@boxcla
Copy link

boxcla commented Dec 23, 2019

Verified that @mxiao6 has signed the CLA. Thanks for the pull request!

sahiga
sahiga previously approved these changes Dec 23, 2019
@mxiao6
Copy link
Contributor Author

mxiao6 commented Dec 23, 2019

Will re-run the tests and merge it after BUIE 11.1.0-beta.27 is released.

sahiga
sahiga previously approved these changes Dec 27, 2019
jstoffan
jstoffan previously approved these changes Dec 27, 2019
@mxiao6 mxiao6 dismissed stale reviews from jstoffan and sahiga via 12065ae December 27, 2019 20:59
@mergify mergify bot merged commit 40eab74 into box:master Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants