Fix: Issue when 'load' event is fired before BoxAnnotations is loaded #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensures that promise to load BoxAnnotations.js completes before loading annotations, even if the viewer 'load' event has already been fired - Re-renders annotations on documents after resize
jeremypress
reviewed
May 11, 2017
| if (this.annotator) { | ||
| this.annotator.setScale(this.pdfViewer.currentScale); // Set scale to current numerical scale | ||
| this.annotator.setScale(this.pdfViewer.currentScale); | ||
| this.annotator.renderAnnotations(); |
There was a problem hiding this comment.
Is this related to loading?
There was a problem hiding this comment.
Forgot to add a comment in the PR for this but nope it is not! When the document is rescaled it wasn't re-rendering the annotations so this fixes that
There was a problem hiding this comment.
I'll add it as a comment in the commit when I merge
JustinHoldstock
approved these changes
May 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.