Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(csv): Emit CSVViewer parse errors silently #1062

Merged
merged 6 commits into from
Aug 30, 2019
Merged

chore(csv): Emit CSVViewer parse errors silently #1062

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fa1eb6b
chore(csv): Emit CSVViewer parse errors silently
Aug 29, 2019
832b9ff
chore: Update error code and sort errors
Aug 30, 2019
772f9af
chore: change to PAPAPARSE_ERROR_TYPES
Aug 30, 2019
1972bf1
chore: using priority map
Aug 30, 2019
f0b0d55
chore: fix CSVViewer tests
Aug 30, 2019
2404791
Merge branch 'master' into csv-parse-errors
mergify[bot] Aug 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/lib/viewers/text/CSVViewer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,18 @@ class CSVViewer extends TextBaseViewer {
if (this.isDestroyed() || !results) {
return;
}
this.data = results.data;

const { errors = [], data } = results;
ConradJChan marked this conversation as resolved.
Show resolved Hide resolved

if (errors.length) {
const error = new PreviewError(ERROR_CODE.LOAD_CSV, undefined, {
ConradJChan marked this conversation as resolved.
Show resolved Hide resolved
...errors[0],
silent: true,
});
this.triggerError(error);
}

this.data = data;
this.finishLoading();
URL.revokeObjectURL(workerSrc);
},
Expand Down