-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(images): Show UI earlier for large multi-page images #1061
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
92f56a4
fix(images): Show UI earlier for large multi-page images
mickr 7794922
fix(images): PR clean up
mickr 9ad59fd
fix(images): Refactored after talking to teammate about structure
mickr a85ad5a
fix(images): Fix JSDoc
mickr 555cc0e
fix(images): Fix JSDoc and rename test
mickr e68d615
fix(images): Fix JDoc and update tests
mickr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,6 +23,7 @@ class MultiImageViewer extends ImageBaseViewer { | |
this.handlePageChangeFromScroll = this.handlePageChangeFromScroll.bind(this); | ||
this.handleMultiImageDownloadError = this.handleMultiImageDownloadError.bind(this); | ||
this.handleAssetAndRepLoad = this.handleAssetAndRepLoad.bind(this); | ||
this.finishLoading = this.finishLoading.bind(this); | ||
} | ||
|
||
/** | ||
|
@@ -90,6 +91,17 @@ class MultiImageViewer extends ImageBaseViewer { | |
.catch(this.handleAssetError); | ||
} | ||
|
||
/** | ||
* Handles the load event for the first image. | ||
* | ||
* @return {Promise} Promise to load bunch of images | ||
*/ | ||
|
||
finishLoading() { | ||
super.finishLoading(); | ||
this.setOriginalImageSizes(); | ||
} | ||
|
||
/** | ||
* Loads the multipart image for viewing | ||
* | ||
|
@@ -151,8 +163,14 @@ class MultiImageViewer extends ImageBaseViewer { | |
this.singleImageEls[index].src = imageUrl; | ||
} | ||
|
||
/** @inheritdoc */ | ||
setOriginalImageSize() { | ||
/** | ||
* Sets the original image width and height on the img element. Can be removed when | ||
* naturalHeight and naturalWidth attributes work correctly in IE 11. | ||
* | ||
* @protected | ||
* @return {Promise} A promise that is resolved if the original image dimensions were set. | ||
*/ | ||
setOriginalImageSizes() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Any tests needed? |
||
const promises = []; | ||
|
||
this.singleImageEls.forEach(imageEl => { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this accurate?