Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Moving thumbnail page numbers #943

Merged
merged 8 commits into from
Feb 26, 2019

Conversation

ConradJChan
Copy link
Contributor

  • Moved the page numbers from overlaying inside the thumbnail image to outside the thumbnail image.
  • Also converted the thumbnail button to an anchor

Old:
screen shot 2019-02-22 at 5 22 49 pm

New:
screen shot 2019-02-22 at 5 20 31 pm

@boxcla
Copy link

boxcla commented Feb 23, 2019

Verified that @ConradJChan has signed the CLA. Thanks for the pull request!

jeremypress
jeremypress previously approved these changes Feb 25, 2019
src/lib/ThumbnailsSidebar.js Outdated Show resolved Hide resolved
@jeremypress
Copy link
Contributor

nit: I think it might look nice if whichever page is selected has the page number on the left get that same black border that the old design had.

@ConradJChan ConradJChan merged commit 3a48a14 into box:master Feb 26, 2019
@ConradJChan ConradJChan deleted the page-number-reloc branch February 26, 2019 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants