Fix: add min-width to video #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @ConradJChan has signed the CLA. Thanks for the pull request! |
jeremypress
approved these changes
Aug 30, 2018
|
Just as a side note: Is the CC button not vertically centered? It looks weird. |
JustinHoldstock
approved these changes
Aug 31, 2018
|
@jstoffan let me know if your hawkeyes see something else
|
|
@ConradJChan, it looks like there's a bunch of unrelated changes from the past few days. Can you make sure there's no merge conflicts? |
ConradJChan
force-pushed
the
cramped-video-controls
branch
from
fdd1065 to
f3dd962
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue is that on minimum sized videos, the video controls get too cramped once you max out the content to be displayed. This means that the video needs have a length in hours, not minutes, as well as close captioning as an option. This is only observed when the hover over the volume control expands out to the right. From experimenting, it appears that no matter how small the video is that is uploaded, the conversion upscales it to minimum 480p and when it's rendered is at least 420px wide.
Before:
After:
The fix was to set a min-width on the video element to be 460px which seems to be wide enough to comfortably render the volume slider, the time display in hours, and the CC button (along with the other default controls).