Skip to content

Commit

Permalink
Fix: vertically center the CC button
Browse files Browse the repository at this point in the history
  • Loading branch information
Conrad Chan committed Aug 31, 2018
1 parent a6e84f3 commit f3dd962
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/lib/viewers/media/Dash.scss
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
video {
cursor: none;
display: block;
min-width: 460px;
max-height: 100%;
max-width: 100%;
min-width: 460px;
width: 100%;
}

Expand Down
6 changes: 2 additions & 4 deletions src/lib/viewers/media/MediaControls.scss
Original file line number Diff line number Diff line change
Expand Up @@ -165,16 +165,14 @@
.bp-media-controls-cc-icon-text {
background-color: rgba($black, .3); // Anything less than .3 looks too transparent on IE/Edge
border-radius: 4px;
bottom: 2px;
color: $white;
display: inline-block;
font-size: 12px;
font-weight: 600;
height: 22px;
height: 24px;
letter-spacing: .1em;
line-height: 22px;
line-height: 24px;
padding: 0 0 0 1px; // Padding left 1px because text isn't perfectly centered on Safari/Firefox even with text-align:center. Looks fine with extra-padding on Chrome/IE/Edge
position: relative; // For lining up the bottom with other buttons in the controls bar
width: 24px;

&:hover {
Expand Down

0 comments on commit f3dd962

Please sign in to comment.