Fix: fix full screen overflow on Windows Chrome #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremypress
commented
Nov 16, 2017
| `Shaka error. Code = ${shakaError.detail.code}, Category = ${shakaError.detail.category}, Severity = ${ | ||
| shakaError.detail.severity | ||
| }, Data = ${shakaError.detail.data.toString()}` | ||
| `Shaka error. Code = ${shakaError.detail.code}, Category = ${shakaError.detail |
There was a problem hiding this comment.
Prettier having fun here
jeremypress
commented
Nov 16, 2017
| @@ -492,7 +491,10 @@ class DashViewer extends VideoBaseViewer { | |||
| resize() { | |||
| let width = this.videoWidth || 0; | |||
| let height = this.videoHeight || 0; | |||
| const viewport = this.wrapperEl.getBoundingClientRect(); | |||
| const viewport = { | |||
| height: this.wrapperEl.clientHeight, | |||
There was a problem hiding this comment.
Looks like windows chrome was giving slightly larger values for getBoundingClientRect. I'll verify this with IE/Edge tomorrow.
There was a problem hiding this comment.
Windows Chrome getBoundingClientRect values: {height: 1275.3333740234375 , width: 1665.3333740234375}
Element clientHeight and ClientWidth values: {height: 1275, width: 1665}
JustinHoldstock
approved these changes
Nov 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.