Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(loading): Update loading ux for pages, thumbnails, preloaders #1355

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

jstoffan
Copy link
Collaborator

@jstoffan jstoffan commented Apr 13, 2021

This change replaces the pulsing three blue bar crawler with a "shine" ghost state effect. Retry of #1353.

Current
loading-current

Updated
loading-placeholder

@jstoffan jstoffan force-pushed the preview-loading-ghost branch 7 times, most recently from 781684a to afd761a Compare April 14, 2021 00:58
@jstoffan jstoffan marked this pull request as ready for review April 14, 2021 01:35
@jstoffan jstoffan requested a review from a team as a code owner April 14, 2021 01:35
@jstoffan
Copy link
Collaborator Author

I ran into an issue with this solution where the background of the pages flashes grey/white when resizing the window. Will investigate and push an update when I can.

@jstoffan jstoffan force-pushed the preview-loading-ghost branch 3 times, most recently from 2c3b83f to dc79c03 Compare April 20, 2021 20:09
@jstoffan jstoffan force-pushed the preview-loading-ghost branch from dc79c03 to c20da85 Compare April 20, 2021 20:31
@jstoffan jstoffan force-pushed the preview-loading-ghost branch from c20da85 to 78b0def Compare April 20, 2021 20:32
@jstoffan jstoffan changed the title feat(loading): Show ghost state for document preloaders and pages feat(loading): Update loading ux for pages, thumbnails, preloaders Apr 21, 2021
@jstoffan jstoffan merged commit fa5dd30 into box:master Apr 21, 2021
@jstoffan jstoffan deleted the preview-loading-ghost branch April 21, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants