Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(a11y): Add meaningful alt text to custom logo #1352

Merged
merged 4 commits into from
Apr 15, 2021
Merged

fix(a11y): Add meaningful alt text to custom logo #1352

merged 4 commits into from
Apr 15, 2021

Conversation

tille
Copy link
Contributor

@tille tille commented Apr 8, 2021

  • Missing alt attribute doesn't compliant a11y standards.

@tille tille requested a review from a team as a code owner April 8, 2021 16:01
jstoffan
jstoffan reviewed Apr 8, 2021
View reviewed changes
src/lib/shell.html Outdated Show resolved Hide resolved
@tille tille force-pushed the a11y-missing-alt-property branch from 771f76a to 2762678 Compare April 9, 2021 01:45
@tille tille requested a review from jstoffan April 9, 2021 17:30
ConradJChan
ConradJChan reviewed Apr 9, 2021
View reviewed changes
src/lib/PreviewUI.js Outdated Show resolved Hide resolved
@tille tille requested a review from ConradJChan April 9, 2021 21:47
jstoffan
jstoffan reviewed Apr 13, 2021
View reviewed changes
Copy link
Collaborator

@jstoffan jstoffan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission, @tille. I think we still need to iterate on the solution a bit.

src/lib/PreviewUI.js Outdated Show resolved Hide resolved
src/lib/PreviewUI.js Outdated Show resolved Hide resolved
@tille tille force-pushed the a11y-missing-alt-property branch from ce9163c to 37c8019 Compare April 14, 2021 22:11
@tille tille requested a review from jstoffan April 14, 2021 22:12
jstoffan
jstoffan reviewed Apr 14, 2021
View reviewed changes
src/lib/PreviewUI.js Outdated Show resolved Hide resolved
src/lib/PreviewUI.js Outdated Show resolved Hide resolved
src/lib/PreviewUI.js Show resolved Hide resolved
@tille tille requested a review from jstoffan April 14, 2021 22:43
jstoffan
jstoffan approved these changes Apr 14, 2021
View reviewed changes
Copy link
Collaborator

@jstoffan jstoffan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for updating!

@tille tille requested a review from jstoffan April 14, 2021 23:04
@jstoffan jstoffan removed the request for review from ConradJChan April 15, 2021 00:32
@mergify mergify bot merged commit 4e11fbe into box:master Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConradJChan ConradJChan ConradJChan left review comments

@jstoffan jstoffan jstoffan approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tille @jstoffan @ConradJChan