chore(resin): Address comments

box · Jun 29, 2020 · b31bcb9 · b31bcb9
1 parent 7d9c27c
commit b31bcb9
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/lib/AnnotationControls.ts b/src/lib/AnnotationControls.ts
@@ -172,7 +172,7 @@ export default class AnnotationControls {
     /**
      * Initialize the annotation controls with options.
      */
-    public init({ onEscape = noop, onRegionClick = noop, fileId = '' }: Options = {}): void {
+    public init({ onEscape = noop, onRegionClick = noop, fileId }: Options = {}): void {
         if (this.hasInit) {
             return;
         }
@@ -188,7 +188,10 @@ export default class AnnotationControls {
 
         groupElement.setAttribute('data-resin-feature', 'annotations');
         regionButton.setAttribute('data-resin-target', 'highlightRegion');
-        regionButton.setAttribute('data-resin-file_id', fileId);
+        if (fileId) {
+            regionButton.setAttribute('data-resin-fileId', fileId);
+        }
+
         regionButton.setAttribute('data-testid', 'bp-AnnotationsControls-regionBtn');
 
         this.onEscape = onEscape;