chore(discoverability): use .each

box · Oct 20, 2020 · 7fa2915 · 7fa2915
1 parent b29629c
commit 7fa2915
Showing 1 changed file with 26 additions and 34 deletions.
diff --git a/src/lib/viewers/image/__tests__/ImageViewer-test.js b/src/lib/viewers/image/__tests__/ImageViewer-test.js
@@ -54,52 +54,44 @@ describe('lib/viewers/image/ImageViewer', () => {
     });
 
     describe('destroy()', () => {
-        beforeEach(() => {
-            jest.spyOn(image, 'removeListener');
-        });
-
-        test('should remove the zoom event listener if enableAnnotationsImageDiscoverability is true', () => {
-            image.options.enableAnnotationsImageDiscoverability = true;
-
-            image.destroy();
-
-            expect(image.removeListener).toBeCalledWith('zoom', expect.any(Function));
-        });
-
-        test('should not remove the zoom event listener if enableAnnotationsImageDiscoverability is false', () => {
-            image.options.enableAnnotationsImageDiscoverability = false;
+        test.each`
+            enableAnnotationsImageDiscoverability | numberOfCalls
+            ${true}                               | ${1}
+            ${false}                              | ${0}
+        `(
+            'should call removeListener $numberOfCalls times if enableAnnotationsImageDiscoverability is $enableAnnotationsImageDiscoverability',
+            ({ enableAnnotationsImageDiscoverability, numberOfCalls }) => {
+                image.options.enableAnnotationsImageDiscoverability = enableAnnotationsImageDiscoverability;
+                jest.spyOn(image, 'removeListener');
 
-            image.destroy();
+                image.destroy();
 
-            expect(image.removeListener).not.toBeCalledWith('zoom', expect.any(Function));
-        });
+                expect(image.removeListener).toBeCalledTimes(numberOfCalls);
+            },
+        );
     });
 
     describe('setup()', () => {
-        beforeEach(() => {
-            jest.spyOn(image, 'addListener');
-        });
-
         test('should set up layout', () => {
             expect(image.wrapperEl).toHaveClass('bp-image');
             expect(image.imageEl).toHaveClass('bp-is-invisible');
         });
 
-        test('should bind zoom listener if enableAnnotationsImageDiscoverability is true', () => {
-            image.options.enableAnnotationsImageDiscoverability = true;
-
-            image.setup();
-
-            expect(image.addListener).toBeCalledWith('zoom', expect.any(Function));
-        });
-
-        test('should not bind zoom listener if enableAnnotationsImageDiscoverability is false', () => {
-            image.options.enableAnnotationsImageDiscoverability = false;
+        test.each`
+            enableAnnotationsImageDiscoverability | numberOfCalls
+            ${true}                               | ${1}
+            ${false}                              | ${0}
+        `(
+            'should call addListener $numberOfCalls times if enableAnnotationsImageDiscoverability is $enableAnnotationsImageDiscoverability',
+            ({ enableAnnotationsImageDiscoverability, numberOfCalls }) => {
+                image.options.enableAnnotationsImageDiscoverability = enableAnnotationsImageDiscoverability;
+                jest.spyOn(image, 'addListener');
 
-            image.setup();
+                image.setup();
 
-            expect(image.addListener).not.toBeCalledWith('zoom', expect.any(Function));
-        });
+                expect(image.addListener).toBeCalledTimes(numberOfCalls);
+            },
+        );
     });
 
     describe('load()', () => {